Peter Saxton
Peter Saxton
Could you open a PR to add this test, even without the fix. However instead of modifying simple app just make the greeting be an enormous binary https://github.com/varnerac/Ace/blob/large_response_reproducer/test/ace/http2_test.exs#L280
@ishikawa this might be fixed by dropping support for older Elixir versions. I am thinking of supporting 1.9 and 1.10 only from the next release.
Looks, good. However the test don't pass in all cases. Is there a limit to the number of times the link can be used?
This is good. Would be good to be able to Run dialyzer against it in travis
@varnerac can you merge the latest master into this branch. Then have a look if dialyzer passes. https://travis-ci.org/github/CrowdHailer/Ace/pull_requests I see a few errors on master but wonder if the improved...
Thanks, could you also add a section to the CHANGELOG
Thanks for the PR @filipecabaco this is definitely the right approach
This looks to break the tests. Can you link me to that depreciation note for OTP21? and add a changelog fixed section for this
hmm. if we want ace to work with 20 and 21 we will need a compile time check on otp version. which is a pain. it's ashame there is not...
@arcz I've created a branch `otp-21-update` so see what would fail with the upgrade.