Ace

Ace copied to clipboard

This looks to break the tests.

Can you link me to that depreciation note for OTP21? and add a changelog fixed section for this

Jul 03 '18 12:07 CrowdHailer

http://erlang.org/doc/man/ssl.html#ssl_accept-1

"Deprecated in OTP 21, use handshake/[1,2] instead."

The problem is that handshake is not present in OTP < 21, I'm not sure how this can be handled, should we wait until next release?

Jul 03 '18 15:07 arcz

hmm. if we want ace to work with 20 and 21 we will need a compile time check on otp version. which is a pain. it's ashame there is not a period of overlap for the two functions

Jul 03 '18 15:07 CrowdHailer

@arcz I've created a branch otp-21-update so see what would fail with the upgrade.

Jul 26 '18 10:07 CrowdHailer

https://blog.voltone.net/post/19

Aug 08 '18 05:08 CrowdHailer

The problem of OTP 21 vs OTP 20 is going to be a non issue because I will support only OTP 21. we need to make this decision to use handle_continue.

Aug 08 '18 16:08 CrowdHailer

I still don't think handle_continue is a big enough feature to justify dropping OTP 20 for...

Sep 19 '18 10:09 nietaki

agreed, but you get this warning just running ace on OTP21

and so this warning is actually preventing us from using warnings_as_errors: true in this project

Sep 19 '18 19:09 CrowdHailer

I think we can probably resolve this now if we upgrade the versions of Elixir and OTP that Ace supports

Apr 01 '20 07:04 CrowdHailer