Chocohead

Results 46 comments of Chocohead

After throwing a breakpoint on this line in `MixinTargetContext`: https://github.com/SpongePowered/Mixin/blob/5c3852753316961ab631a6574f3ef0fc2729c1db/src/main/java/org/spongepowered/asm/mixin/transformer/MixinTargetContext.java#L562 It seems like the only conditions where `md` is present, renamed, and has the same original name as `methodRef` but...

Perhaps it might, let's export the results with `-Dmixin.debug.export=true` and compare: Starting with the interface `TestMixinA`, a combination of `@Accessor`s and `@Invoker`s, using 0.8.1 the result is ```java @Mixin({ TestTarget.class...

How are you launching the game and which mods are you using? I'd expect you'd only get this crash if Loader is picking the wrong jar as the Minecraft game

You might want to be following the [FabLab's venture](https://github.com/FabLabsMC/fabric-loader/tree/feature/modproviders) into allowing this.

I'm not sure it's especially necessary to have a specific mapping type for records. As ever the JLS is [specifically vague](https://docs.oracle.com/javase/specs/jls/se15/preview/specs/records-jls.html#jls-8.10.3); but either the record components do have to match...

> > > Ive had a deeper dive into records and do think that basing the component names off the field names is the way to go. Javadoc can be...

I wouldn't have said that Loader is really in a state to be using it for non-Minecraft related things whilst still expecting it to work readily without changes. Given it...

There is an expectation that an exception might propagate up from the game, but only `Exception` (so your generic `Throwable`, `Error`, etc. will leak out): https://github.com/FabricMC/fabric-loader/blob/62dec491951127559a597ea13bd0194ced70fe6a/src/main/java/net/fabricmc/loader/game/MinecraftGameProvider.java#L215-L230 Of course this is...

> Hmm, since fabric loader calls main by reflection, isn't any throwable from there wrapped in an [invocation target exception](https://docs.oracle.com/en/java/javase/15/docs/api/java.base/java/lang/reflect/InvocationTargetException.html) than be thrown directly as in method handles? https://docs.oracle.com/en/java/javase/15/docs/api/java.base/java/lang/reflect/Method.html#invoke(java.lang.Object,java.lang.Object...) Thinking...

More that it should provide platform independent exception handling, you can't trust that whatever launched Loader is going to do it in a useful way. I'd also say this is...