James Lucas

You _might_ be missing the `get_log_probs` function. I say might as your point is still relevant. I chose to have `predict` return the class labels and hid the probabilities in...

> I know, patch or STFU Ha! No, it's _really_ valuable to be made aware of these things. It is also an option to change the api - we have...

Another great PR! Looking forward to reviewing. After glancing through quickly - I think you should add a feature gate for the datasets module as discussed in #115

Awesome! Thank you so much for these PRs - sorry that it's taking me a little while to look through them properly as well. This is another algorithm I'm not...

Sorry I forgot to comment on this again. Thanks for making those changes - I think that this is probably ready to be merged now. Before I do merge I'd...

I think this is a really good suggestion. There is some difficulty with adding regularization, as this should happen outside of the `compute_cov` function. We could handle this in a...

I'm still holding out hope that I will be able to pick things up in this project again soon. Unfortunately, for now my schedule is a little too intense for...

I agree with your evaluation. I don't have time to support any serious development directly. I would be happy with either option (a) or (b) going forwards. If somebody wants...

Thanks for your time on this. I'll take a look through the code and see if I can make sense of anything.

I've had a brief look and things look very solid! I'll hopefully have time to properly review this in the next few hours. Thanks for all the effort you've put...