James Lucas

Results 112 comments of James Lucas

Yes this is indeed standard. I had thought about implementing this before but I'm not sure how exactly it should look. Certainly I'd like GMM to be accessible without the...

I'm afraid I've been away from the rust ecosystem to understand this issue without digging deeper. Should this PR be closed following @tafia 's comment?

This looks fine to me (but it is a lot of code to check over). It looks like the library may be getting some actual maintenance soon ( #199 )...

Thank you for this! I've been hoping to make LDA a part of rusty-machine for a while now :). Sadly I'm no expert on LDA and I am particularly busy...

Thanks for your patience. I finally have some time to look through this and leave some comments. I'm still not too familiar with LDA but hopefully can provide some meaningful...

I haven't read all your comments but from your summary I think your approach sounds great. Keep the core algorithm as it is and we can write up an issue...

> Also, transformer current requires the input and output of the transform to be of the same type Ah yes, that is true. I'm not sure whether we want to...

There is actually an (in?)active PR right now for PCA ( #158 ). Maybe @sinhrks can say whether he will want to continue this or pass it on. I'd say...

Yes, please feel free to suggest any other techniques! t-SNE would be a cool one to have added. I think that dimension reduction is an algorithm that the current rusty-machine...

I haven't formalized anything yet and I think it will be good to address it after reviewing the API for training (as discussed in #120). With that said the only...