Assaf Katz

Results 49 comments of Assaf Katz

@bje- This project is no longer being actively maintained by its original autoher (see #236). You might want to migrate to the community maintained fork [bats-core](https://github.com/bats-core/bats-core) and report your issue...

> > > And I haven't added any unit or E2E test. I was wondering if we should test it and what to test and how to do it. >...

> > > Could you explain more about what points 2, 3 and 5 mean? I didn't understand them properly 2 - Ensure that if the command failed without color,...

> > > What's the benefit of 4 (single line check) if 5 does a complete check? 4 is working for JSON also, I agree that for YAML is redundant...

> > > About 2 - Why would the error code change because of this option? Only when highlighting has some issues (error), there will be a non-zero exit code...

> This project doesn't have much flags, so all good. Just wondering in general 😅 I think that this is question for @itaysk and should be documented somewhere.

> > > Do we surely need the full output check? I think we can trust the library and just check that the option works - that is, invokes the...

@karuppiah7890 [The library that this code rely on](https://github.com/andreazorzetto/yh/blob/master/highlight/highlight.go), which in turn depended on [another library which isn't working well on Windows](https://github.com/logrusorgru/aurora#windows). I didn't check it personally, but it is something...

Hi, Actually, this is a specific use case for a general one. For example, we want to remove helm.sh/chart label. I suggest allowing a parameter of a blacklist of annotations...

Hi, I have stupid question - why does this operator need to change the /etc/hosts in first place? This file is managed by k8s... Thanks