0x-mesh
0x-mesh copied to clipboard
0xProject
A peer-to-peer network for sharing 0x orders
In PR #857, I didn't notice that we needed to sync to the database before code review. This indicates a lack of testing that should be remedied.
# Context Please provide any relevant information about your setup - Are you running Mesh in the browser or as a standalone server? Are running Mesh inside of Docker or...
# Context Augur has reported this issue on Discord. Please provide any relevant information about your setup - Are you running Mesh in the browser or as a standalone server?...
Currently custom order filters are implemented as JSON schemas. This offers a lot of flexibility and allows users to filter out orders based on pretty much any criteria, however it...
The current implementation of the ordersync protocol is naive and could be improved. Some changes to consider are: 1. Request orders from multiple peers in parallel. 2. Drop providers that...
Our process for validating incoming orders is complicated, and the code that does so (`meshSpecificOrderValidation`, `onchainOrderValidation`, `orderwatch.Watcher.add`, etc) is spread out and somewhat inconsistent. This is largely a relic of...
There are some tests which we currently don't run in the browser (they are excluded by build tags) but should be able to. For example, look at the `orderwatch` package....
PR #793 introduced a large change to Mesh that completely overhauled the database layer. In the file `db/sql_implementation.go`, several handwritten queries were created. These queries could create maintenance issues down...
Comments (and code names) frequently contain typos. These typos can be caught in code review, but this is an inconsistent and time consuming way to catch the issues. The best...
See https://golangci-lint.run/usage/configuration/. Currently we only enable `errcheck` and `govet` but we could look into enabling more linters.