0x-mesh icon indicating copy to clipboard operation
0x-mesh copied to clipboard

Improve custom order filters

Open albrow opened this issue 5 years ago • 1 comments

Currently custom order filters are implemented as JSON schemas. This offers a lot of flexibility and allows users to filter out orders based on pretty much any criteria, however it comes with a downside: it is not possible to efficiently query the database for orders that match a particular JSON schema. The current implementation of ordersync has to iterate through all orders in the database and test each one to see if it matches the JSON schema individually. This approach works fine for lower numbers of orders but will not scale well.

We should restructure custom order filters such that it is possible to efficiently find all orders in the database that match a given filter. https://github.com/0xProject/0x-mesh/pull/793 lays some of the groundwork which would make this possible.

albrow avatar Jun 09 '20 01:06 albrow

If we're improving things, we should also look at having the ability to dynamically change custom order filters. It's something Augur specifically has asked for.

albrow avatar Jul 02 '20 00:07 albrow