Simone Berni

Results 27 comments of Simone Berni

The issue talks about manage the secrets through a GUI. This allows to configure them in the Django Admin interface and, even if technically is a GUI, I do not...

I saw the review pop up and though that you was almost done :D Nono keep going, having a complete frontend is absolutely better!

On the review, i normally give a feedback about the entire code of the PR. If you want to have a discussion, ask stuff, or simply confirm that the "path"...

Ok this is tricky. Long story short, django works this way: For each app in settings, it calls the `ready` *before* doing the migration. Meaning that, if in the `ready`...

In this case, the error is caused by ```python3 def ready(self): from .serializers import AnalyzerConfigSerializer # to avoid import issue set_permissions(settings.DEFAULT_CACHE) # we "greedy cache" the config at start of...

This should fix it. If you can, test it a little bit manually to ensure that it works, but I'm quite confident: ```python3 import sys class AnalyzersManagerConfig(AppConfig): name = "api_app.analyzers_manager"...

Cool! I thought about some corner case, so we could even add the call `AnalyzerConfigSerializer.read_and_verify_config()` inside the file `wsgi.py`, that should be called once everything from Django has been set...

Tests still fail 🤔 Let's try the wsgi.py road?

In my opinion, we could work in 2 steps: the first one, is to make the secret manageable by the GUI globally, so that we are just adding this new...

Just an overall comment on the code: i really like the structure, it follows all the other IntelOwl code, and it is well structured. Nothing to change on that side,...