Inderpreet Singh Chhabra

Results 14 comments of Inderpreet Singh Chhabra

Hi @getao i was wondering what to use for --task for pertaining edgeformer for summarization?

Hi @alaradirik, I have added seaformer implementation in modeling file and updated the conversion and configuration scripts, I have ran a forward pass in notebook and output is same as...

Hi @alaradirik thanks for the detailed review :) I have uploaded the converted model to the hub here Inderpreet01/seaformer-semantic-segmentation-large, will work on your comments and update the pr. Thanks

Hi @alaradirik I have worked on the changes you mentioned, two tests are failing in test_modeling_seaformer.py SeaformerModelTest::test_initialization - AssertionError: -6.169999778649071e-06 not found in [0.0, 1.0] I have normally initialized the...

Also I have worked on the checks and most of them are successful, will need your help with the remaining three checks. thanks.

Hi @alaradirik, thanks for your response, removing `num_labels` from config has resolved that testcase, can you please help with this test case as well `SeaformerModelTest::test_initialization - AssertionError: -6.169999778649071e-06 not found...

actually this test is getting skipped in segformer model which also initializes weights normally.

Hi @alaradirik thanks for reply, where should i create this test with the same name?

Hi @alaradirik can you please do the final review? thanks

@alaradirik thanks for the review, @amyeroberts sure will ping you once model is ready