Greg Smith
Greg Smith
Are you seeing this error?  If so, I assume this is because the example ads are in a format that cannot be...
I made a PR that I think might work for this, would you mind trying it out? https://github.com/videojs/videojs-contrib-ads/pull/455
Can this issue be reproduced in the [example integration](https://github.com/videojs/videojs-contrib-ads/tree/master/examples/basic-ad-plugin)? It is difficult to debug this without a reduced test case, or know which project the issue lies within.
For the steps to reproduce, are you using the example implementation in this repo or a different implementation?
I tried out your VAST example and it seemed to work normally for me. Maybe I don't understand what the bug is. The ad states are part of the videojs-contrib-ads...
If the current public API is insufficient, let's figure out what we need to add. Do you know why ad ends + ad errors was insufficient?
I believe you mean Require.js rather than React.js in the title, yes? It appears this issue is inherited from [generator-videojs-plugin](https://github.com/videojs/generator-videojs-plugin). I have opened [an issue](https://github.com/videojs/generator-videojs-plugin/issues/193) there. When a fix is...
This would be a lot easier to fix in the 6.x codebase. I believe this is where you'd start. https://github.com/videojs/videojs-contrib-ads/blob/master/src/states/Preroll.js#L170 Off the cuff, maybe you'd want to add the class...
It's back up!