videojs-contrib-ads
videojs-contrib-ads copied to clipboard
No loading spinner after the preroll ad has finished and before the actual content starts.
All of the following concerns only the HTML5 version. I haven't tested the flash fallback.
Here is how to reproduce it:
- open the example page (the one under example/index.html) with chrome
- while the preroll add is still playing enable device mode in the chrome dev tools and set network throttling to GPRS (or similar)
- After the preroll ad finishes the poster is displayed but there is no spinner to indicate that new content is being loaded. This confuses users that are on a slow connection into thinking that they should click the post for the video to start or that the video stream is down.
Expected behavior: The usual videojs loading spinner should be shown indicating that a new video stream is being loaded.
Good point. Thanks for the report.
I have a PR #295 in review to address this and other instances where the loading spinner is neither displayed nor animated.
This would be a lot easier to fix in the 6.x codebase. I believe this is where you'd start. https://github.com/videojs/videojs-contrib-ads/blob/master/src/states/Preroll.js#L170 Off the cuff, maybe you'd want to add the class there (if it's not already there) rather than removing it. I haven't tested that though.