videojs-contrib-ads icon indicating copy to clipboard operation
videojs-contrib-ads copied to clipboard

No loading spinner after the preroll ad has finished and before the actual content starts.

Open svetlin-mladenov opened this issue 10 years ago • 3 comments
trafficstars

All of the following concerns only the HTML5 version. I haven't tested the flash fallback.

Here is how to reproduce it:

  1. open the example page (the one under example/index.html) with chrome
  2. while the preroll add is still playing enable device mode in the chrome dev tools and set network throttling to GPRS (or similar)
  3. After the preroll ad finishes the poster is displayed but there is no spinner to indicate that new content is being loaded. This confuses users that are on a slow connection into thinking that they should click the post for the video to start or that the video stream is down.

Expected behavior: The usual videojs loading spinner should be shown indicating that a new video stream is being loaded.

svetlin-mladenov avatar Jun 15 '15 09:06 svetlin-mladenov

Good point. Thanks for the report.

dmlap avatar Jun 24 '15 19:06 dmlap

I have a PR #295 in review to address this and other instances where the loading spinner is neither displayed nor animated.

RevinKey avatar Nov 06 '17 21:11 RevinKey

This would be a lot easier to fix in the 6.x codebase. I believe this is where you'd start. https://github.com/videojs/videojs-contrib-ads/blob/master/src/states/Preroll.js#L170 Off the cuff, maybe you'd want to add the class there (if it's not already there) rather than removing it. I haven't tested that though.

incompl avatar Feb 28 '18 22:02 incompl