Finn Plummer
Finn Plummer
Great thanks. I will be AFK until the 15th, but can fix it up when I have my laptop again. Otherwise, feel free to apply your suggestions and merge. Sorry...
Sweet. Feel free to ask me any questions on how the ntt op lowering is implemented. There is also a (messy) initial implementation of turning poly.mul into ntt ops here:(https://github.com/inbelic/heir/commit/2e0f6d5682060b5d1b72bd4a8838398d35d861c3)....
Note to self: currently does not have any check if the operands are actually in the range `[0, cmod)`
Failing testcase is unrelated. Will need to rebase on review changes.
Rebased to resolve conflicts.
Regarding the comments about differentiating between `OpSDot/DotProduct` and `OpSDotKHR/DotProductKHR`: I agree that these are different ops/capabilities in the SPIR-V spec. However from a quick attempt to implement this, I found...
Rebased to help resolve merge conflicts. Thanks a lot for the time and reviews. Really helpful and I learned a lot.
What is the status of this pr?
I agree, I think we should be able to postpone any of the modulus based logic to a later lowering. I will set aside time this evening to do a...