İnanç Gümüş

Results 197 comments of İnanç Gümüş

@grafana/k6-browser, we might want to tackle this next. So, we can replicate the remote behavior locally, too. We can get more feedback from OSS users.

Hi @dirtydiesel46. Thanks. What you described in this issue description is by design. Still, we can consider changing this behavior.

@ankur22 This works (click on the element with the Command key (on macOS)): ```javascript export default async function () { const page = browser.newPage(); await page.goto("https://k6.io/", { waitUntil: "networkidle" });...

@ankur22 100% agree on unit testing and refactoring :-) As a start, we can start to run tests faster by doing some simple fixes over here and there. For example,...

Yes, this doesn't have to be a "let's go, optimize it all up" approach, but we can still make fixes from time to time. IMO, it's also good to know...

@SunstriderEx I believe this feature works as expected, as the scenario environment variables are only for user scripts. However, the environment variables provided by the command-line are for the k6...

For homebrew, before building, try: ```bash export LD_LIBRARY_PATH=$(brew --prefix openssl)/lib export CPATH=$(brew --prefix openssl)/include export PKG_CONFIG_PATH=$(brew --prefix openssl)/lib/pkgconfig ``` Then: ```bash make ```

Any idea why don't we use `vu.Context()` [here](https://github.com/grafana/xk6-browser/blob/0654e7a7bd0ae5d75351e1ea2b187d9ecd6c9f31/browser/module.go#L72-L102)? ```go func (m *RootModule) NewModuleInstance(vu k6modules.VU) k6modules.Instance { // ... browserRegistry: newBrowserRegistry( context.Background(), // why isn't this vu.Context()? ... ``` --- When...