İnanç Gümüş comments

Results 197 comments of


                                            İnanç Gümüş

Panics and errors when `clearPermissions` called on a `BrowserContext`

Possibly related: #442

tap position option doesn't offset the position as requested

It's the same issue with `Page.tap`. This issue is not related to locators as a locator is only a forwarder to the inner method that do the actual job. I...

`ExecutionContext.evaluate()` hangs tests on macOS in CI

I couldn't reproduce this on my Mac: `macOS Big Sur 11.6 (20G165)` :( CI is a different beast.

`setDefaultTimeout` on `BrowserContext` isn't converting the time correctly

Should we both support Playwright-like integers and k6-like human-readable ones to keep the compatibility promise? We can do that by wrapping the k6 one. I'm also OK with directly using...

Allow specifying log level per component

From a practical angle, I'd love to see **what a component does and what CDP messages it sends and receives**. For example, I can filter by the `Page` component and...

Allow specifying log level per component

> This feature should be aimed primarily at users, so we might want to lump all internal logs under the internal component/category. WDYT? That makes sense 👍 As you said,...

Error closing the WebSocket connection at end of test

> I'm using the latest published version. Hi, @unlikelyzero, the latest released version doesn't contain the latest fixes. Please try using the `main` branch as explained by @imiric before: >...

Linter issues

@imiric Is this PR (#211) also closing this issue?

Linter issues

So maybe update the issue description and also change its name to "vet isn't working properly" since we fixed the linter errors? Or create another issue as you explained as...

Linter issues

But we still fixed the following and I think we better change the issue description and link it to that comment maybe: > The lint job in CI currently [ignores...