Simon Frei comments

Results 295 comments of


                                            Simon Frei

draft: use db instead of storing items to be handled in memory while pulling

I was thinking timeout as an item count isn't necessarily well correlated with time spent processing. Anyway, details - we could always combine both if necessary. However what seems simple...

Pretend/Announce that ignored files/directories have been deleted

I personally am quite hisitant about such a feature, as being too easy to delete data. Even if it's opt-in, users have a tendency to mess with settings and either...

fix(db): drop index IDs when dropping all files (fixes #10469)

Followup to the above review comment: https://github.com/syncthing/syncthing/pull/10478#pullrequestreview-3521402176 Retracting the requesting changes review - while the question of dropping the device index remains (see below), the change in this PR is...

fix(db): drop index IDs when dropping all files (fixes #10469)

You likely mean this change, right? https://github.com/syncthing/syncthing/commit/cf1cf85ce60c87c01abd7162eb9cb28f31a8446a Looks like the behaviour was the same before it, i.e. it also didn't remove the index IDs on `DropAllFiles`. Anyway, doesn't really matter...

fix(db): drop index IDs when dropping all files (fixes #10469)

Argh right. Also the sequence is tracked together with the index ID in the DB, and afaik in the (hypothetical) scenario where the remote announces an index ID and non-zero...