Simon Frei

Results 295 comments of Simon Frei

`fs.ExpandTilde` calls `filepath.FromSlash` - that seems to conflict with whatever the `if build.IsWindows` block here is trying to achieve. Also that call might lead to complications/unintended modifications if the command...

I still don't think converting from slashes to native path separators is a good idea here (what `fs.ExpandTilde` does), especially not if done on just one part of the argument....

> Does somebody know why `shellquote.Split` is executed in `Archive` for every single file and not only once in `newExternal` when the folder is instantiated? I don't know, and agree...

Likely related to https://github.com/syncthing/syncthing/issues/7879. Might also be a duplicate, but the steps/scenario are different.

Unfortunately the log is truncated, the relevant parts are missing. If you could capture logs with ADB while the crash occurs that'd be great. Also might be related to https://forum.syncthing.net/t/how-to-safely-downgrade-on-android/22616/23

I didn't mean to say you truncated it. The logs being truncated in that dialog is a known issue. We just need the full trace to see what's happening, no...

The formatting is quite weird and there's duplication, no idea why. This seems to be the relevant bits: > panic: already released > > > goroutine 105 [running]: > goroutine...

I think both the previous and new behaviour aren't ideal: If proxies are expected to be a "hiding"-feature then no fallback should be default (might still expose real connection even...

Indeed it is. I'll write an update there and keep this open and pinned to hopefully get the attention of anyone else wondering about it.

Just in case anyone subscribed to this issue: It won't be relisted. See readme and https://github.com/syncthing/syncthing-android/issues/2064#issuecomment-2424797592 for more info.