Eric Cheng comments

Results 79 comments of


                                            Eric Cheng

feat!: use wrapped functions

> New downsides for now: it gets a little bit more complex for new contributors to add a new function > as they would need to declare the TypeScript definition...

feat(finance): branch code option in bic()

Seems like `validator.isBIC` does not recognize `XK` (Kosovo) as a country code, it intermittently fails when `XK` is the country code

feat(finance): branch code option in bic()

> > Seems like `validator.isBIC` does not recognize `XK` (Kosovo) as a country code, it intermittently fails when `XK` is the country code > > Maybe report this to validatorjs...

Always use max param as exclusive value

> I looked a bit into the code, and somehow applying this change feels wrong 🤔 I'm not so sure anymore if we want this > > Some example usages...

feat(name): add ```hyphenated``` option to ```lastName()```

> I am interested in this issue. May I be assigned, please? Sure!

ci: auto npm publish script

> @import-brain Do you still need the branch? If not, please delete it. Done

Reimplement internet.password() with more generation options

> This looks interesting, I might provide a PR for this in the near future. @xDivisionByZerox Are you still willing to work on this?

Reimplement internet.password() with more generation options

> If you want to work on this, feel free. I already have a branch that implements this if you want to take a look. I'm on my phone, so...

> As we will have a blog soon 🥳 (see: [expressjs.com #1483](https://github.com/expressjs/expressjs.com/issues/1483)), it's time to start thinking about the content. > > Here are some ideas about recent events that...