faker
faker copied to clipboard
feat(finance): branch code option in bic()
closes #1158
Codecov Report
Merging #1378 (3fcb070) into main (ea8d873) will increase coverage by
0.00%. The diff coverage is100.00%.
Additional details and impacted files
@@ Coverage Diff @@
## main #1378 +/- ##
=======================================
Coverage 99.62% 99.63%
=======================================
Files 2163 2163
Lines 241264 241275 +11
Branches 1014 1018 +4
=======================================
+ Hits 240357 240392 +35
+ Misses 886 862 -24
Partials 21 21
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/modules/finance/index.ts | 100.00% <100.00%> (ø) |
|
| src/modules/internet/user-agent.ts | 88.09% <0.00%> (+6.34%) |
:arrow_up: |
Tests dont pass
Also: https://github.com/validatorjs/validator.js/blob/master/src/lib/isBIC.js
Seems like validator.isBIC does not recognize XK (Kosovo) as a country code, it intermittently fails when XK is the country code
Seems like
validator.isBICdoes not recognizeXK(Kosovo) as a country code, it intermittently fails whenXKis the country code
Maybe report this to validatorjs for them to fix?
Seems like
validator.isBICdoes not recognizeXK(Kosovo) as a country code, it intermittently fails whenXKis the country codeMaybe report this to validatorjs for them to fix?
https://github.com/validatorjs/validator.js/issues/2045