faker icon indicating copy to clipboard operation
faker copied to clipboard

feat(finance): branch code option in bic()

Open import-brain opened this issue 2 years ago • 6 comments

closes #1158

import-brain avatar Sep 18 '22 15:09 import-brain

Codecov Report

Merging #1378 (3fcb070) into main (ea8d873) will increase coverage by 0.00%. The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1378   +/-   ##
=======================================
  Coverage   99.62%   99.63%           
=======================================
  Files        2163     2163           
  Lines      241264   241275   +11     
  Branches     1014     1018    +4     
=======================================
+ Hits       240357   240392   +35     
+ Misses        886      862   -24     
  Partials       21       21           
Impacted Files Coverage Δ
src/modules/finance/index.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 88.09% <0.00%> (+6.34%) :arrow_up:

codecov[bot] avatar Sep 18 '22 15:09 codecov[bot]

Tests dont pass

Shinigami92 avatar Sep 20 '22 06:09 Shinigami92

Also: https://github.com/validatorjs/validator.js/blob/master/src/lib/isBIC.js

ST-DDT avatar Sep 20 '22 12:09 ST-DDT

Seems like validator.isBIC does not recognize XK (Kosovo) as a country code, it intermittently fails when XK is the country code

import-brain avatar Sep 20 '22 15:09 import-brain

Seems like validator.isBIC does not recognize XK (Kosovo) as a country code, it intermittently fails when XK is the country code

Maybe report this to validatorjs for them to fix?

ST-DDT avatar Sep 20 '22 15:09 ST-DDT

Seems like validator.isBIC does not recognize XK (Kosovo) as a country code, it intermittently fails when XK is the country code

Maybe report this to validatorjs for them to fix?

https://github.com/validatorjs/validator.js/issues/2045

import-brain avatar Sep 20 '22 17:09 import-brain