harmony icon indicating copy to clipboard operation
harmony copied to clipboard

Rename local pow() to avoid issue with next Armadillo

Open eddelbuettel opened this issue 3 years ago • 1 comments

Hi harmony team,

The next release of Armadillo will have a slightly expanded arma::pow() function. In harmony you flatten the namespace so your local pow() helper then gets confused with what (Rcpp)Armadillo will bring. One possible fix (suggested by Conrad) is to rename your helper; this PR does that. I tested it first against the release tarball and now against git, and R CMD check continues to pass.

It would be helpful to if you could update harmony with a simple spot release as we then will not have to discuss 'changes' with CRAN. We will probably look into releasing a new RcppArmadillo within two or three weeks. You are of course under no obligation to change this, but are likely to then hear from the CRAN maintainers with firmer language .

Let us know if you have questions.

Cheers, Dirk

eddelbuettel avatar Sep 21 '22 12:09 eddelbuettel

Update: Conrad actually finalized Armadillo 11.4.0 so I am tempted to upload RcppArmadillo 0.11.4.0.0 which means you may hear from CRAN about this.

eddelbuettel avatar Sep 22 '22 20:09 eddelbuettel