Trung Dang

Results 5 comments of Trung Dang

@miaowing can u please help review this change. If possible I would like to have it asap for my project :) instead of using hacky way. thanks

I suspect the issue because of `this.behaviors = [];` in the code below https://github.com/sinonjs/sinon/blob/bda67f6d54c7f2512d507de45ae9ac007d8a60cb/lib/sinon/stub.js#L122-L138

@mroderick Here is my current code to solve the problem. ```js export const newSandbox = () => { const sandbox = sinon.sandbox.create() .usingPromise(Promise); // sandbox.reset_ = sandbox.reset.bind(sandbox); sandbox.reset = ()...

@fearphage thanks. From my understanding, it will also override native Promise which may coz concerns and not very good for all cases. What do you think?

@mroderick I prefer to change behaviour of `reset` in sandbox. When reset a sandbox, it should not remove the registered Promise