Greg Hale comments

Results 50 comments of


                                            Greg Hale

Are proto2 extensions supported?

@Xorlev I'd love to understand your proposed solution better, so I could try to implement it. We need the `google.http.api` extension at work. One thing in particular I didn't understand...

GET request with request body results in a 400/bad request

Thanks for the breakdown. I'm tempted to say: let's let the user decide if they want to comply with the HTTP spec or not, re: request bodies in GET requests....

Hashable-independent Aeson instances

This has been merged via #1242

fix musl float arithmetic and move it into sub-library

Is this PR obsoleted by https://github.com/kadena-io/pact/pull/1184 ?

[WIP] Memoization tables

@jmcardon Think I should close this PR? Did we decide that all L2-related work will be against pact-core?

[WIP] Memoization tables

@jmcardon Think I should close this PR? Did we decide that all L2-related work will be against pact-core?

Add tests for multiple access of request body

This should be fixed since I've copied over `Delayed` routing; but leaving this issue open until I write a test to verify.

Sample code for authenticated api. (Docs)

This is a great question. I will have to do a little research because I've only used Snap's auth snaplet for authentication (cookie auth). I wrote a little in this...

Linking to some prior discussion on this topic: https://github.com/Gabriella439/grace/issues/53 (one big difference is that #53 is talking about adding builtin type synonyms, while it looks like you want user-defined type...

chore(domain): adds domain model, based on APIs, and various inputs

Would it be good to include the `Command` and `CommandResult` types that are used to hit pact-service?