pact icon indicating copy to clipboard operation
pact copied to clipboard

fix musl float arithmetic and move it into sub-library

Open larskuhtz opened this issue 1 year ago • 2 comments

On some systems the c implementation of transcendental float arithmetic could result in wrong results due to conflicts with symbols in the system libm.

This PR

  • simplifies the implementation of transcendental float arithmetic by removing redundant code and making all symbols that aren't used directly by Haskell FFI static, and
  • moves the implementation into a sub-library in order to make debugging and testing easier.

larskuhtz avatar Apr 02 '23 22:04 larskuhtz

Is this PR obsoleted by https://github.com/kadena-io/pact/pull/1184 ?

imalsogreg avatar Apr 10 '23 17:04 imalsogreg

Is this PR obsoleted by #1184 ?

I would call this PR an improvement upon it. Except that now, this PR is only doing a pure code reorg, and no longer attempting to fix an issue.

jwiegley avatar Apr 10 '23 18:04 jwiegley