Christoph Hormann

> We also need weir and lock_gate as polygons because they are used in the water-barriers-poly layer. We could think about removing support for polygon weir and lock_gate. As the...

> It turns out that we don't render them! There is no styling in water-features.mss for weir and lock_gate as polygons. Even worse: We render `waterway=weir` polygons with label only...

12k uses, almost all of them in Ireland, the vast majority on polygons. At this stage this is very region specific in its use and we'd get significantly ahead of...

This should be fixed by #5045.

Current situation w.r.t. various tags for swimming/bathing related features: * `leisure=sports_centre` (+ `sport=swimming`): 23.4k uses, rendered with name label and bright green fill on polygon * `leisure=water_park`: 12.8k uses, rendered...

> however, I would say the tag covers a quite specific type of facility This is not really a subject for discussion here - but if that is indeed the...

For the basics yes, but #4431 dealt with a number of additional issues which were not part of #4978. #5027 discusses some of them. I am therefore closing this, but...

Thanks for the review. That would make this ready for merging. Are there any comments if #5125 is preferrable over this? Otherwise i would merge this and any improvements from...

We are currently under-documented w.r.t. PostgreSQL/PostGIS version requirements and i opened #5129 about this. Postgresql 17 could be useful for test environments because of improved analytic features (`EXPLAIN`).

Just a quick note for information: What this change introduces is not considered a suitable application of OpenStreetMap Carto by the OSM-Carto designers. Guidelines for this can be found on...