iap
iap
The primary motivation is to run the server on the main thread, so it works the same way as when you run it as web server. Originally, as the comment...
Running the event loop in a new thread is inconsistent with `run_as_web_server`, so if there is any code relying on running in the same thread, it will misbehave. For instance,...
> Do you have something specific in mind here? I can't think of anything that would need to be initialized in the same thread as the async event loop. Generally...
simplified and removed extra flag. tested by running the app in window, and tested error condition when webview not installed.
@Aran-Fey @mad-moo are you guys ok to merge this or would like me to make more changes?
@mad-moo - addressing your questions/concerns one by one 1. **Simplification** - while the last revision simplifies by removing the switch and committing to the new behavior, the overall complexity is...
@Aran-Fey - thanks for the comments. 1. yes, code in `rio.__init__` will be executed in the subprocess again (on all platforms, of course). I did not see any noticeable performance...
@Aran-Fey To address these issues, I can move `webview_shim` into a new separate top-level package (e.g. `rio_webview`, located on the same level as rio) and switch to using `subprocess` to...
> If possible I'd like to avoid creating a 2nd top-level module. Maybe you can avoid it by using python's `-c` flag? Or maybe webview even has a command line...
@Aran-Fey the initialization code is not aware of on_app_start - it's just a python application that may at some point decide to pop up a dialog (powered by rio). it...