Manuel Tumiati

@stovmascript I don't think that it's needed because if it is managed by the environmental variable it must be kept as it is. But tests are always good, so we...

@alradadi we added a regex that detects any environmental variable with this shape $(VARIABLE) here is the function ```javascript /** * Determine if the given property is managed by an...

thanks @archansel. We should detect if the version is managed by environmental variable first, and then change the MARKETING_VERSION and CURRENT_PROJECT_VERSION accordingly

@stovmascript I checked #186 by @archansel. As he said these values are written in MyProject.xcodeproj/project.pbxproj. They should be easy to update

IMHO it will be better to manage both cases in order to have full compatibility

I finally added test to handle the case. @stovmascript you can check it out and decide to merge or not the pull request

related to pull request #162

@stovmascript both commits are already within this pull request. You can merge this one and close the other with a comment

why not to migrate to hardhat? I did it here https://github.com/w1nt3r-eth/hot-chain-svg/pull/11

we are working to migrate the library to full typescript. Here is our first implementation https://github.com/Satellite-im/P2PT/tree/typescript-migration