Andrey Loskutov

Results 414 comments of Andrey Loskutov

The change here is coming from https://github.com/eclipse-xtext/xtext/issues/3524 investigation.

@szarnekow : if you have time, would be good if you could check this PR.

> Also I think some changes are better a separate PR Could you please point which exactly?

> Each of those can be an own PR > > * Removed dead code in AnnotationModel.cleanup because mapLock can't be null. > * Added new javadoc to IAnnotationMap.getLockObject() >...

I've rebased on https://github.com/eclipse-platform/eclipse.platform.ui/pull/3399 state, fixed merge conflicts & my own comment above.

Test failures on Windows are unrelated. @mehmet-karaman, @laeubi : please feel free to review.

@mehmet-karaman : you have now two commits, I assume by mistake. Can you please have **one**?

This is javadoc from `org.eclipse.jface.text.source.AnnotationModel` > All modifications of the model's internal **annotation map** are synchronized using the model's lock object. This is javadoc from `org.eclipse.jface.text.ISynchronizable`: > In order to...

- I can't reproduce, but I don't have CDT installed - What are the "Keys" preference page says for Ctrl+PageDown? - Does it happen with other files, like *.txt and...

Which editors are used for C++ and xml files? Could it be, it is generic editor in both cases? Another idea: Do you have webtools installed, and is xml editor...