Andrey Loskutov

Results 414 comments of Andrey Loskutov

I'm not sure the change improves readability. Is this PR manually crafted of is the result of automated quick fix?

> I have did it manually Why not with a cleanup? Or there is nothing available?

> even via this that file is not getting picked and updated That is the sign that the quick fix doesn't have an automated solution for conversion (yet). > Can...

> @iloveeclipse Your change request is pending here. Is the PR good according to you? It is not mine and I've answered already above: https://github.com/eclipse-platform/eclipse.platform.ui/pull/2816#issuecomment-2684899239

I prefer to close this PR, I don't see any value in this change and the time ro properly review is not worth it.

Could you provide screenshots before/after, it would be easier to understand.

Thanks. Do you observe this only in the dark theme? I'm not used to it, so I never saw this yellow background on breakpoints. Or is this something non-default you...

Reopening, original fix caused regression and was reverted via https://github.com/eclipse-platform/eclipse.platform.ui/pull/3231

> We have migrated our eclipse based application from eclipse 4.15 to eclipse 4.26 Whatever issue we had in 4.26 is irrelevant, as it might be already fixed in 4.35....