Illarion Koperski
Illarion Koperski
From my experience, the Shopify theme parser accepts minuses only on the outer side of the `schema` tag: ```liquid {%- schema %} { "name": "My cool section" } {% endschema...
I like the `@enter/@exit` naming schema. Would it also make sense to omit those internal-use actions from the final machine methods, i.e., the machine should not have `machine.enter()` and `machine.exit()`...
The camelcasing transform would rename the methods to `.enter()` and `.exit()`, wouldn't it? I think having literal non-camelcased `machine['@enter']` methods is ok, as long as the developer can define their...
This question is related to #16, see [comment from Feb 27, 2018](https://github.com/krasimir/stent/issues/16#issuecomment-368790055) in particular. Stent produces self-powered state machines, i.e., machines that fully control themselves. In my opinion, adding onEntry...
@rkoshy, thank you for a detailed example and a comprehensive pull-request. Reserved entry/exit actions might be useful in many scenarios. Personally, I would [create a custom middleware](https://github.com/krasimir/stent/blob/master/docs/middlewares.md) or use the...
As temporary solution in my projects, I add my own 'response' event listener and log an additional line for the request if it responded with 4xx status code. I log...
I vote: - Keep .min file - Remove .mq method - Only native elements - Keep the cushion option - Flat directory - ESLint - Pages as default branch Thanks...
I was wrong, the issue is not related to version 3 only because the [`let` keyword was introduced in February commit](https://github.com/jamesplease/react-request/commit/cceddcca2f8322aa859e078ec2a6d651f416dc93). Still, would you consider transpiling the library files to...
I've solved the issue for my project by importing `react-request/dist/react-request.js` which is already transpiled.
Hi @jamesplease! I'm using Browserify and UglifyJS 3. [Uglify supports ES5 only.](https://github.com/mishoo/UglifyJS2) Webpack users might experience the issue too because most configurations exclude the `node_modules` folder in [babel-loader config](https://webpack.js.org/loaders/babel-loader/). The...