box2dweb-closure icon indicating copy to clipboard operation
box2dweb-closure copied to clipboard

Published 20 hours ago • verified publisher icon illandril

Compiler warnings.

Open firecow opened this issue 11 years ago • 5 comments

With the new google closure compiler, you have like 700 warnings... Mostly because private members are accessed publicly.

firecow avatar Mar 19 '13 07:03 firecow

Actually i have a version of your box2d, where i have fixed all the private warnings, and a lot renaming of functions so they fit the gjslint.

If i push to this branch would you accept them, or should i just leave them in my branch ? I was just thinking it might be a good idea to have the right naming convention, in this branch as well.

I guess you can just have a look at my branch and merge what ever changes you want. :-D

firecow avatar Mar 19 '13 09:03 firecow

I would not accept a push with renaming, because I want people to need to make as few changes as possible to switch over from a different Box2D implementation.

Also, it looks like at least some of your warnings fixes made things public that are supposed to be private. The correct fix would be to fix the accesses, not make them public.

illandril avatar Mar 19 '13 15:03 illandril

Roger that.. Ill keep the fork up, if anyone wants a gjslinted version.

firecow avatar Mar 19 '13 15:03 firecow

I just did some work to reduce the number of warnings in my fork (I took care of about half of them so far), and added a mention of your fork in the readme to help anybody who wants a gjslinted version.

illandril avatar Mar 19 '13 17:03 illandril

Super...

I'll keep the linted version up-to-date...

I'm so busy complaining that i forgot to thank you for making a google closure version of Box2D :D So thank you :D

firecow avatar Mar 19 '13 18:03 firecow