Ilia Ivanov

Results 9 comments of Ilia Ivanov

Hi @ruidan, Great job! I wonder why are the results above different from the reported in the article? ![image](https://user-images.githubusercontent.com/19606164/47954675-f5b5ec00-df9d-11e8-8400-0e8f1cfd55b4.png) Is it random seed or something else? Can we reproduce the...

@ThiagoSousa thank you! Shame on me for not noticing that detail.

@leonardbinet can I get access to push this one, please?

I think @GuoqiangOu 's questions come down to the next one: - why `type_of_target([[0, 0.5]]) == 'continuous-multioutput'` and not `'continuous'`? - it contradicts with the documentation indeed, as well as...

In the last commits I addressed the comments regarding documentation, csc_matrix and explicit zeros. It seems to be done to me. Please take a look, somebody 🙏 cc @glemaitre @rth

thanks @jnothman 🙌 > > why type_of_target([[0, 0.5]]) == 'continuous-multioutput' and not 'continuous'? > > It has two columns. It does, however the documentation (of the function) says "'continuous-multioutput': `y`...

btw I can't change the PR description, but it also fixes https://github.com/scikit-learn/scikit-learn/issues/18611 now

> Is there sense in rejecting a full "sparse" matrix with no zeros and two nonzero values? I have to add, this logic hasn't been introduced by the PR, the...

Hey @anonymous-author-here! I'm really glad it's helpful! :) You can cite the original paper mentioned in README, or the repo directly if you want to refer to the implementation ✌️