Ivan Litteri

> The `compiler` job failure seems transient, but the `clippy` one isn't. I saw that the clippy warning was added in another PR. Do you think that we should address...

Can [this](https://www.electronjs.org/docs/tutorial/using-pepper-flash-plugin) be the reason?

> Hmm for some reason in the description the code has some encoding issues: > > ``` > commit_criteria: Vec<Box<dyn L1BatchPublishCriterion>>, > proof_criteria: Vec<Box<dyn L1BatchPublishCriterion>>, > ``` > > Can...

@slowli, I solved both suggestions, let me know if there's anything else to do for this PR.

> Not sure whether CI failure is expected, but AFAIU it's caused by the base branch; the changes in this PR look fine. Thanks for all the feedback! I'll double-check,...

> @ilitteri also btw now that it's extracted to a separate function, it probably should be easy to integrate this check to EN as well (as a separate PR). Thanks...

> @ilitteri also btw now that it's extracted to a separate function, it probably should be easy to integrate this check to EN as well (as a separate PR). @popzxc...

> @ilitteri On EN `eth_client_url` is a part of required config, and you can see it being used e.g. to instantiate the consistency checker. Right now, `ConsistencyChecker` takes a URL...

> * The contracts submodule seems not to be pointing to the right commit despite it is correctly set in `.gitmodules`, which causes the `Verifier` deployment to fail, because we...

The integration tests that are failing are fixed in https://github.com/matter-labs/zksync-era/pull/1270 and https://github.com/matter-labs/zksync-era/pull/1296. We can wait for #1270 to be merged to pull from the base branch, but this PR can...