Iliar Turdushev

Results 41 comments of Iliar Turdushev

What if we add `IHttpClientBuilder` only on those .NET versions that support C# 8, i.e. support default interface property implementation: ```csharp public interface IHttpStandardResiliencePipelineBuilder { #if NET6_0_OR_GREATER IHttpClientBuilder HttpClientBuilder {...

> Mm.... This makes me concerned. Would this pass [package validation](https://learn.microsoft.com/dotnet/fundamentals/apicompat/package-validation/overview)? @RussKie It seems that the validation passes. Please, take a look at the following PR #5215. All checks have...

> Langversion is not tied to a TFM, but instead to the tooling which can vary. @joperezr AFAIK default interface implementation (DIM) relies on the runtime to identify whether DIM...

@abatishchev We are considering adding the `HttpClientBuilder` property. Could you, please, look at the summary below and confirm it? I'm also wondering what's the real use-case for the `HttpClientBuilder` property....

Since it is unlikely that anybody will intentionally register both the resilience and the hedging handler in a single HttpClient, the only scenario that will benefit from the proposal is...

> What if someone does, what would it mean for the API? How would that use case pan out? At the moment, we do nothing to prevent users from that,...

We've got a similar ask. We adopted `OpenTelemetry.Instrumentation.Http` `1.0.0-rc9.14` and `EnrichWithHttpRequestMessage`, `EnrichWithHttpResponseMessage`, and `EnrichWithException` to populate custom tags. We were using handlers `EnrichWithHttpResponseMessage` or `EnrichWithException` to execute some "final" logic...

Changing the default behavior to not retry non-idempotent calls would be a breaking change, since some customers already rely on current default behavior. What if we introduce a new method...

> I like the idea of disabling retry for non-idempotent HTTP methods by default and giving the flexibility of enabling/disabling retry for any HTTP method. > > Since this could...

I agree with @geeknoid. Let's not change the behavior we have and try and make disabling retries for non-idempotent HTTP methods easier. What if we introduce an extension method on...