Ikuru K

Looks like this line does not register the namespace alias if the position of `:refer` and `:as` are different. https://github.com/jonase/kibit/blob/ed2f8e57d28e77037f806a8ffa8da53efb308245/kibit/src/kibit/check/reader.clj#L64

Plus there is an incompatibility with new versions of liquibase-slf4j, apparently. Would be a good idea.

I don't actively use accountant anymore, but I can merge PRs.

@p-himik Is this related to https://github.com/venantius/accountant/issues/66 ? Either way happy to review a patch!

Hey @ikitommi thanks for looking. > Thanks! About the impl, I believe if you just bound the name to (-> spec st/get-spec st/spec-name) is might work. Just want to update...

Just throwing in my 2 cents that a ClojureScript hiccup returning strings would make sense, and a separate fn/macro to return raw doms would also make sense. Even more awesome...

Just another :+1: form me

thanks for the feedback! will take a close look at them later! On Sat, Aug 5, 2017 at 4:38 AM, Alex Miller wrote: > *@puredanger* commented on this pull request....

@puredanger Overall thanks for making this so much better! I think I addressed your comments, but let me know if I missed something or there is anything else to do...

@puredanger ping?