Ivan Krivosheev

Results 182 comments of Ivan Krivosheev

@billy1624 @tyt2y3 can you review this PR?

@DDtKey @tyt2y3 hello! I create PR.

> Cool. Is this all you want to remove? @tyt2y3 yes, there are deprecated methods.

> wave Hey @billy1624! Happy to claim this if it's okay with you! Done!

> @billy1624 @ikrivosheev I have a question: > > Is this [concrete implementation of `prepare_table_index_expression`](https://github.com/SeaQL/sea-query/blob/e9f961eb760d81f80817aae61f502eba409846dd/src/backend/index_builder.rs#L5-L14) for the `IndexBuilder` still necessary if each backend has its own custom implementation? 1. `prepare_index_name`...

> @ikrivosheev Thanks, but each backend also has a `prepare_table_index_expression ` with these methods called inside their definition: > > * [MySQL](https://github.com/SeaQL/sea-query/blob/6a30dbc017f8892c300010f9d0487c54d63ae936/src/backend/mysql/index.rs#L4-L13) > > * [Postgres](https://github.com/SeaQL/sea-query/blob/6a30dbc017f8892c300010f9d0487c54d63ae936/src/backend/postgres/index.rs#L4-L14) > > * [Sqlite](https://github.com/SeaQL/sea-query/blob/6a30dbc017f8892c300010f9d0487c54d63ae936/src/backend/sqlite/index.rs#L4-L13)...

@kirawi hello! Any updates? Or I can close PR?

@anshulxyz hello! Thanks you for interest in this issue! If I can help you let me know.

@AaronM04, hello! I see `bzip2 = "0.4"` is published. Can you close issue?

It's a double: https://github.com/mdsteele/rust-cab/issues/14.