sea-query
sea-query copied to clipboard
issues-118 Add SubQuery operator
PR Info
- Closes https://github.com/SeaQL/sea-query/issues/118
- https://github.com/SeaQL/sea-query/issues/216
Adds
- SubQuery operators:
EXISTS,ALL,ANY,SOME
@billy1624 @tyt2y3 can you review?) I have done.
@billy1624 @tyt2y3 hello! I have small question. Expr::ne have signature: pub fn ne<V: Into<Value>>(self, v: V) -> SimpleExpr. If i rewrite this method to: pub fn ne<V: Into<SimpleExpr>>(self, v: V) -> SimpleExpr will not be so convenient to use for simple queries and it is breaking change.
Should I add new method?
What is the best way to name new methods? For example:
ne_expr?expr_ne?- Something else?)
Hey @ikrivosheev, good suggestions!! I do think we need eq_expr and ne_expr inside Expr. That's definitely nice to have.
Hey @ikrivosheev, good suggestions!! I do think we need
eq_exprandne_exprinsideExpr. That's definitely nice to have.
@billy1624 hello! Done
Hmm, @billy1624, I think about new method... Maybe is better impl From<T> for SimpleExpr, where T is all types for Value? And after that we don`t need new method. What do you think?
Hmm, @billy1624, I think about new method... Maybe is better
impl From<T> for SimpleExpr, where T is all types forValue? And after that we don`t need new method. What do you think?
@tyt2y3 what do you think about it?
@billy1624 @tyt2y3 done! I add impl<T> From<T> for SimpleExpr and everything works without the new method!
@billy1624 @tyt2y3 can you review this PR?