Tommi Reiman

Results 447 comments of Tommi Reiman

The `sci.api/evaluator` could also do #369 optimization behind the scenes.

tested with dropping all var-mappings from `namespaces`. Before: After: empty is not anyway useful, but I think it shows the limit how small it could go. The useful minimal would...

You need to mount `swagger-feature` as a middleware|interceptor, which adds the valid keys to the route data for the routes `swagger-feature` effects

e.g. all specs from mw/int `:spec` key accumulate to the route spec. Would be great to see the accumulated spec per endpoint.

I think the right solution is to remove the top-level `:tags` completely and use path `[:swagger :tags]` instead.

oh, it a breaking. but the `:tags` has never been part of the route spec, so this is still a bug fix. need to push a minor out with this....

Hi. If you look at the `match`, it should have the original templated string, recall under `:template` key.

Hi. I think the merged routers is not right: you should merge both routes and route data. Instead of merging routers, I propose you either: 1) create two separate `ring/ring-router`...

I think the error is originating from somewhere else as it says the response body is a map, and for coercion errors you are giving a String. I would look...

Definitely! A design draft would be good way to start, e.f. via example what goes to route data, what goes to mw options etc.