Tommi Reiman

Results 442 comments of Tommi Reiman

Had to revisit how the entry walking works, this is not good: ```clojure (defn walk [schema] (m/walk schema (m/schema-walker identity) {::m/walk-entry-vals true})) (-> [:map [:x :int]] (walk) (walk) (walk)) ;...

> I considered reusing ::walk-entry-vals but it could be a breaking change. I think it's a bug that the entries are kept after walking, so it would be ok to...

Agree that there are real problems here: 1. people use `string?` instead of `:string` 2. lot's of extra dispatching (transformers, generators etc) Original issue is [here](https://github.com/metosin/malli/issues/264) and I did a...

I would like to sunset the predicate schemas from the default registry. Too many ways to do the same thing now. This could be part of Malli 1.0.0 as it...

Quick comments: * base into `reitit.middleware` which defines concept of `:handler`, `ring` uses it * `:handler` paths are known in the `:compile` hook, different for middleware & ring, this is...

PR most welcome on this.

Hi. This doesn't work with middleware either: ```clojure (defn mw [handler k v] (fn [req] (handler (assoc req k v)))) ;; flat list ((middleware/chain [[mw :a 1] [mw :b 1]]...

Hi. This is unfortunate. Humanized errors do not have a multimethod to support easy extension of schema-based errors. With current design, you need to add a property to the schema...

Would you like to add to add the `[:type-properties :error/message]` data to the time schemas? PR most welcome on this!

`lein not found`, build seems broken.