Igor Katson

Results 90 comments of Igor Katson

I can take a closer look later (need to see locally with and IDE), but high-level comments so far. First of all, thanks for the contribution. Removing hacks is good,...

Overall, I don't hate it, but I don't love it. The little hack was pretty innocent but made things simpler I think - as it was all structured types without...

> I'm not sure it's worth it without creating a general abstraction like "WithRawValueAndHash" above. I'm not sure it's worth creating that abstraction either though - hard to tell without...

> Turns out there was a BTreeMap in the serializer Ah, right, I remember doing it now. I did it this way, so that it doesn't matter if the passed-in...

So after thinking about it for a bit here's what I see: 1. I think the existing "f**ing hack" as I called it in the code is alright, not too...

Sounds good @anacrolix , I'll leave it up to you.

A few things: > I don't suppose you could check this branch out in your IDE and help me solve the single compile error I have left? There you go...

A similar thing was merged in recently, so this is no longer needed. We now store reference-counted bytes, both the full info, and the deserialized one

Thanks for kind words @jabedude! As for BTv2, in a nutshell - I'm not against it, but I'm not convinced it's where time should be put in next. I looked...

Hey @crisidev, it's not obvious to me why this would be useful, I assume something like this exists in other clients? Can you elaborate on a use-case, and describe how...