Israel Herraiz

Results 11 comments of Israel Herraiz

Then I think you should submit the changes in the documentation along with the changes in the code. The documentation should match the code at all moments.

Please could you sign the CLA with the same email address that you are using in the commits of this pull request? That's a pre-requirement to be able to accept...

Hi @JoshiNeh, please let us know if we can help by reviewing any new changes.

The build is failing with this error: ``` Some files need to be formatted in ./examples/dataflow-streaming-schema-handler - FAIL ./examples/dataflow-streaming-schema-handler/src/main/java/com/google/cloud/pso/pipeline/PubsubToBigQueryJSON.java ./examples/dataflow-streaming-schema-handler/src/main/java/com/google/cloud/pso/util/BigQueryConverters.java ```

This pull request has been inactive for over a year. I am going to close it at this point. Please don't hesitate to reopen it if you can address the...

Most of the comments I made have not been addressed. There are no changes to the Python code, the same issues remain. Please could you take a look at the...

Is anyone out there? :)

assign set of reviewers

I have uploaded new commits that should be addressing all the comments that I have resolved. Each commit should each issue separately, so it would correspond to a single comment,...

Another round of commits just added, each commit should roughly correspond to one of the resolved comments.