ihmc-open-robotics-software
ihmc-open-robotics-software copied to clipboard
Slider doesn't update when COM height set via ROS API
Required Info | |
---|---|
Version or commit hash | sylvain-maintenance-trip-local |
Sim or Real Robot | Valkyrie Unit D |
Operating System | Ubuntu 14.04 |
JDK | 1.8.0_111 |
Steps to reproduce issue
- Set the COM height with slider 8
- Update the COM height via the ROS API
- Move slider 8 by a nudge
Expected behavior
The slider should be updated/moved when the ROS API modifies the corresponding value.
Actual behavior
Really rapid increase of COM as slider causes jump in value
Contributors with relevant knowledge or expertise (optional)
@dljsjr
Are there any differences between sylvain-maintenance-trip-local
and the sylvain-maintenance-trip
branch that got merged in to the 0.9 release?
Here are the differences: https://github.com/openhumanoids/ihmc-open-robotics-software/compare/sylvain-maintenance-trip...openhumanoids:sylvain-maintenance-trip-local - nothing really that could affect the sliders
Thanks, I wouldn't think there would be anything that would impact the sliders I just wanted a record of the diffs so we can figure out how to get you a patch or something
Yo! So it's my bad, the YoVariable that the slider board is hooked on is simply poorly updated in the controller. There is no straightforward fix at first glance as the height control is somewhat complicated (there are three types of input to deal with: from the walking controller, from the messages, and from the YoVariable). I'm afraid that a quick fix would result in introducing a new bug. We'll let you know if we can figure out a fix for it though. Sorry for the bad news.
Thanks for the explanation Sylvain - I see the issue. Is there a way to have a smooth transition instead if triggered by slider board? So if abs(current-desired)>epsilon
it will have a maximum change rate?
Since 0.10, once a ROS message with the height has been set both the virtual and the actual sliderboard are not "responded" to anymore - i.e. once the height has been adjusted once via messages it cannot be adjusted via sliders anymore.
Version: release/0.10.0 Java Version: 1.8.0_161
cc @VladimirIvan
I believe at one point @georgwi was looking in to this