em-http-request

em-http-request copied to clipboard

Fix GitHub Actions failures and add Ruby 3.3 to CI

2

My initial GitHub Actions CI workflow that I provided in #357 had mistakes that are currently causing it to [fail](https://github.com/igrigorik/em-http-request/actions/runs/7405077029) on the master branch. This PR fixes those failures. I...

mattbrictson

Add a safeguard against [header injection attacks](https://en.wikipedia.org/wiki/HTTP_header_injection). There is no bug in em-http-request as such, but this patch removes an attack vector when the library is used to fetch user-provided...

c960657

EM-HTTP-Request depends on [cookiejar](https://github.com/dwaite/cookiejar) which is incompatible with Ruby HEAD due to [recent changes](https://github.com/ruby/ruby/commit/08e449d89baf1aeee87f084e1cd55bfe3b9cc46a) in the URI module in Ruby core. cookiejar is EOL'd, so it should probably be replaced...

c960657

I am seeing exception messages expanded to: `X509_STORE_add_cert: cert already in hash table` while the test is for exactly `cert already in hash table` as seen here: https://github.com/igrigorik/em-http-request/blob/91cee5919ec97a06ebdcf35b4edf3c2cf4b8ec4a/lib/em-http/http_connection.rb#L56 Not sure...

vanjabucic