em-http-request icon indicating copy to clipboard operation
em-http-request copied to clipboard

"cert already in hash table" condition falling through

Open vanjabucic opened this issue 8 months ago • 0 comments

I am seeing exception messages expanded to: X509_STORE_add_cert: cert already in hash table while the test is for exactly cert already in hash table as seen here:

https://github.com/igrigorik/em-http-request/blob/91cee5919ec97a06ebdcf35b4edf3c2cf4b8ec4a/lib/em-http/http_connection.rb#L56

Not sure when the error message changed but should we have a more lenient test of: e.message =~ /cert already in hash table/ ?

Without it it fails to connect due to a raised exception.

System: Amazon Linux 2, ruby 3.3.2

vanjabucic avatar Jun 13 '24 18:06 vanjabucic