Ilya Grigorik

Results 288 comments of Ilya Grigorik

> I think this might be only the case if you use em-syncrony's ActiveRecord's client and ActiveRecord calls only, no cheating by grabbing a database connection from ActiveRecord and running...

Hard to say. If you're running on the same server (with fiber-pool, or on Goliath, etc), then it means it's something within Devise itself that may need to be patched.

You might be better off asking on devise issue tracker (or mailing list).

The description is confusing me, but the code makes sense. :-) @calj how does that look to you? any unexpected behaviors that we would need to guard for?

@calj I've tested the Fiber pool theory in the past, and to my own surprise, it didn't come out any faster.. I was playing with this within the core of...

Hmmm, wow.. I am _really_ surprised this hasn't show up before! Nice one :-) This seems to do the trick for me: ``` ruby require 'em-synchrony' EM.synchrony do start =...

@funny-falcon's patch seems to do the trick.. but I'm having a hard time trying to figure out the actual patch in there :-)

So, do we want to merge any of this into master? If not, I'll close the bug.

Toby, currently em-synchrony only patches the find methods in em-mongo: https://github.com/igrigorik/em-synchrony/blob/master/lib/em-synchrony/em-mongo.rb#L62 Sorry about the confusion with this.. Two things we can do: (a) extend the patch to more methods, or...

FYI: https://github.com/igrigorik/em-synchrony/pull/98