Ilya Grigorik

Results 288 comments of Ilya Grigorik

@canghai908 ah, I see, thanks for the context. Current code doesn't do `Simultaenous-Use` checks: https://github.com/igrigorik/node-spdyproxy/blob/master/lib/radiushelper.js#L76-L96 It would have to be extended to support this use case.

The content disposition part is not part of this fix.. since this gem is just the encoder / decoder, but the escaping would be important to fix. @flori: any thoughts...

@ChadBailey are you still game for / have time to land the merge?

Stumbled across this awesome gem https://github.com/kciter/vimgolf-finder by @kciter...

@kinosang not currently, you'd have to extend the current radius code to add those kinds of limits.

They're tiny, what's the motivation? :)

Hmm, perhaps.. I'm open to it, probably not a big patch if you're open to exploring it. :)

Well, that's unfortunate. Reading through the options, none of them strikes me as a good substitutes and I don't think we're willing to hand curate these either. As such, the...

First off, thank you for working on this! 🙇Second, yikes.. 51 tests? Stepping back, would it make sense to break this into multiple PR's? Worried that it might get unwieldy...

@HoneyryderChuck sorry about the delay, started reviewing this earlier but keep stumbling over scope and breadth of all the changes. Given some of the outstanding comments both from myself and...