Igor

Results 11 comments of Igor

Situation * React is loaded via `@wordpress/element` * Version of `@wordpress/element` is depending on the WordPress version * We need to support multiple versions * Upcoming is WP 6.2 where...

Looking with @uxkai and @manuelaugustin we: Found problems in the First time configuration. The existing CSS is using border still, while this PR changes that to be ring. So will...

Besides some merge conflicts, these are my changes during/after rebase: [Replace babel config](https://github.com/Yoast/wordpress-seo/pull/20944/commits/c2e6f18e1db04761e01ad964de0477a9c705a330) needed adaptation for added sourceMaps : * Using `api.env` * Removing previous `api.cache` due to that picking...

This gave quite some trouble, with help from Dennis we've managed to find the root cause: `__forceInitialArgs` always set to `true` inside the docs page. Meaning Storybook does this on...

I'm having doubts if this is the best UX to offer. It is a valid image and could potentially be frustrating to a user if the user can still select...

A couple of extra things to note for the Facebook Description: - Any HTML should get stripped. - A fallback description should be used when the description is empty. Currently,...

Good point, maybe it is fine. Still would be nice to be confirmed though. And the moving out of the test folder still remains.

As discussed with Anton, repurposing this PR for only the first point (moving from the test folder). The second (no A11yNotice styled components output in snapshots) is no longer important...

Extend does not seem to work like we thought... There are problems with specificity amongst others. Going to close this issue.

Retesting this, let's add some more detail. In the block editor (Gutenberg), marking does work with some known attributes like `id` and `class`, but not with custom attributes. In the...