Igor Benav comments

Results 116 comments of


                                            Igor Benav

SQLModel classes fail type checking with FastCRUD

Thanks, @slaarti, I'm fixing this one ASAP!

SQLModel classes fail type checking with FastCRUD

Totally forgot about this (a bunch of new stuff came out), I'll work on it

SQLModel classes fail type checking with FastCRUD

Closed by #112

Add Nested Routes Support and Documentation

I'll take a proper look at it later today

Add Nested Routes Support and Documentation

Sorry, had a really long day. I'll try to do it on friday

Add Nested Routes Support and Documentation

That's great!

Make `is_deleted` Field Optional and Configurable in Soft Delete Logic

Hey, @gal-dahan, can you fix the typing?

Make `is_deleted` Field Optional and Configurable in Soft Delete Logic

> Hi, I did it. Can you approve the PR? ‫בתאריך יום ב׳, 19 באוג׳ 2024 ב-2:53 מאת ‪Igor Benav‬‏ :‬ Nice! Sorry for the delay

handle no deleted_at col

Here we got: ```sh FAILED tests/sqlalchemy/crud/test_delete.py::test_delete_soft_delete - assert None is not None + where None = .deleted_at FAILED tests/sqlalchemy/crud/test_delete.py::test_soft_delete_with_custom_columns - AssertionError: Record should have a deletion timestamp assert None is...

handle no deleted_at col

Btw this is related to #88, so you may want to fix this one as well (being necessary to have either `is_deleted` or `deleted_at`). Plus, this change is pretty big,...