igorbenav
Make `is_deleted` Field Optional and Configurable in Soft Delete Logic
Pull Request Template for FastCRUD
Description
This pull request introduces changes to make the is_deleted field optional and configurable in the soft delete logic of the FastCRUD class. This issues https://github.com/igorbenav/fastcrud/issues/88
Changes
Added logic to conditionally update the is_deleted column based on its presence in the configuration. Updated the soft delete process to only set the is_deleted field if it is explicitly configured.
Tests
No new tests have been added yet
Checklist
- [ ] I have read the CONTRIBUTING document.
- [ ] My code follows the code style of this project.
- [ ] All new and existing tests passed.
Hi, I did it. Can you approve the PR?
בתאריך יום ב׳, 19 באוג׳ 2024 ב-2:53 מאת Igor Benav < @.***>:
Hey, @gal-dahan https://github.com/gal-dahan, can you fix the typing?
— Reply to this email directly, view it on GitHub https://github.com/igorbenav/fastcrud/pull/152#issuecomment-2295440528, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP7TFBPHFAMEGIZ2PBU4NTTZSEXY5AVCNFSM6AAAAABMO4FMWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJVGQ2DANJSHA . You are receiving this because you were mentioned.Message ID: @.***>
Hi, I did it. Can you approve the PR? בתאריך יום ב׳, 19 באוג׳ 2024 ב-2:53 מאת Igor Benav < @.***>:
Nice! Sorry for the delay