Igor Raits

Results 128 comments of Igor Raits

Fair enough. https://src.fedoraproject.org/rpms/luajit/pull-request/2

I think we should consider merging libcomps into libhif.

This sounds like a bug in swig, not in libdnf... isnt' it?

I hope internally this could do something partially decoding base64 (since you can decode it by chunks), you don't need full string to be available.

yes, something like that. Unfortunately, I'm still in the middle of understanding how to chain FlateReader from flate2, so I can't come up with syntax how I would like to...

Also I'm not sure whether it should be BufRead or just Read

```rust impl EntitlementCertificate { pub fn from_file(file: &str) -> Self { let path = Path::new(file); let rdr = BufReader::new(File::open(path).unwrap()); let b64iter = rdr.lines() .skip_while(|l| l.as_ref().unwrap() != ENTITLEMENT_DATA_HEADER) .skip(1) .take_while(|l| l.as_ref().unwrap()...

@Zygo any plans to fix this?

@M00nF1sh can you check / approve / merge please?

I think as long as we mirror what koji would do, it would be safe.