aws-load-balancer-controller icon indicating copy to clipboard operation
aws-load-balancer-controller copied to clipboard

feat: Specify Managed Prefix List for access control

Open yo-ga opened this issue 1 year ago • 4 comments

Issue

  • Resolves kubernetes-sigs/aws-load-balancer-controller#2167

Description

  • Add new annotations for Managed Prefix List
  • Combine the IP addresses and Managed Prefix Lists
    • User can add IP addresses and Managed Prefix Lists at the same time

Checklist

  • [x] Added tests that cover your change (if possible)
  • [x] Added/modified documentation as required (such as the README.md, or the docs directory)
  • [x] Manually tested
  • [x] Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:

  • [x] Backfilled missing tests for code in same general area :tada:
  • [ ] Refactored something and made the world a better place :star2:

yo-ga avatar Feb 18 '24 08:02 yo-ga

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: yo-ga / name: Yoga Yu (8bdd72e68555d25fdf66b941d641ff6235284953, 1f35253df08773ec02f6e8f06603e51c8b90138b, d9ff3ee74b43285c55021914d6fc2ab83992260c, dd587fc41aad5447d1887dbe90281a9729563132, 51c59981db512ff83c7c1297b7e7a597fac7d6ad, b8f72a7303f469e666de292deade69d0d5846619, 1853b99787e29496780d94c4091a2d59e5f851ac, 415f98e70a0dc4e48b48ffc3489429cac078c2e4, 66afd137ca25b5faf7aeea8508f305ace8e4181c)

Welcome @yo-ga!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Feb 18 '24 08:02 k8s-ci-robot

Hi @yo-ga. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 18 '24 08:02 k8s-ci-robot

@yo-ga, sorry for late response, and thanks for your contribution. I left some comments.

oliviassss avatar Mar 13 '24 23:03 oliviassss

Hi @oliviassss , kindly confirm the change and the reply

yo-ga avatar Mar 14 '24 14:03 yo-ga

/ok-to-test

oliviassss avatar Mar 14 '24 16:03 oliviassss

Hi @oliviassss, the test seems well.

yo-ga avatar Mar 15 '24 14:03 yo-ga

/lgtm /assign @M00nF1sh

oliviassss avatar Mar 15 '24 16:03 oliviassss

@M00nF1sh can you check / approve / merge please?

ignatenkobrain avatar Apr 11 '24 17:04 ignatenkobrain

@oliviassss @M00nF1sh Any news?

yo-ga avatar Apr 17 '24 12:04 yo-ga

@M00nF1sh hello, any update on this? Thank you

bohuslav-broza avatar Apr 24 '24 13:04 bohuslav-broza

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, yo-ga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 24 '24 17:04 k8s-ci-robot

Hi @M00nF1sh , one more thing to ask, when will the feature be released?

yo-ga avatar Apr 25 '24 17:04 yo-ga

Hi @oliviassss and @M00nF1sh , same question as @yo-ga , is there an estimation on when will this be released?

dcodix avatar May 16 '24 17:05 dcodix

I just tested v2.8.0 and it seems to be working. Thanks!

dcodix avatar May 20 '24 21:05 dcodix